Skip to main content

Design review prior to Code review

Is it really necessary to design review before performing Code Review? Why is it so important?
I asked Security Ninja and what he replied was quite convincing. As I am new to Code Reviews I can't comment on that but his reply make thing more clear for me:

"Nilesh asked a question about the last blog post which I want to answer here. He asked whether the design review was required prior to performing the source code review. I feel like I’m sitting on the fence when I say that it depends on your SDLC and organisation but it really does. In a well structured SDLC with security integrated into each phase you could be reviewing the design a long time before the code itself. The design items have a couple of different uses in my eyes. They give you guidance when reviewing the design for an application from a security point of view and help you either sign off or reject the design. The second benefit of these checklist items is to check whether the code you are reviewing matches up to the design you signed off."

To understand the Design properly a presentation by the designer will help.The design will have already been checked for quality,the designer will have had experience explaining it to a small group and at least a minimal set of drawings (models) will have been constructed. This will allow for a concise,understandable presentation. Given the quality of the presentation, more people will understand more important details of the design.

You can find Guidelines for Conducting Design and Code Reviews here in precise format:


Popular posts from this blog

File Upload through Null Byte Injection

Sometimes, during file upload we come across situation wherein there would be check on the file extension at the client side as well as server side too. If the application does allow only .jpeg extension to be uploaded, the client side java script checks for the extension of the file before passing the request. We all know that how easily this can be defeated.
Some applications, checks for the extension at the server side also. That's not easy to bypass. However there are some ways with which it still can be bypassed. Most of server side scripts are written in high level languages such as Php, Java etc who still use some C/C++ libraries to read the file name and contents. That leads to the problem. In C/C++ a line ends with /00 or which is called Null Byte. So whenever the interpreter sees a null byte at the end of the a string, it stops reading thinking it has reached at the end of the string.
This can be used for the bypass. It works for many servers, specially php servers. Th…

SQL Injection in search field

Earlier I had written about performing SQL injection in search field and how to do a DoS attack and privilege escalation using 'Like' operators. Now another SQLi exploitation I came across recently. That too in the search field. This becomes important as lots of people don't pay much attention on the search forms/ fields in the application. My aim is to show that a search form can also be exploited with SQL Injection. The following queries are based on a real world exploitation. The steps and data are for just illustration purpose only. Suppose, the search form provides the details of users who have accessed the application some time and their login time details etc, we just need to provide their name in the search box provided. All the data were being going as Post request. So, to just fingerprint the database, I provide, 'nil'+'esh' in the search field and it successfully gives me the results. That means the database behind the application is concatenat…

Insecure protocols

Some basic insecure protocols and risk associated with them: