Skip to main content

Mould it as per your need

We had a discussion with our colleagues over XSS issue found in one application. Initially there was not input validation at all-you can insert simple script tag and execute XSS. Following our recommendations they filtered out certain special characters like (>,<," etc) also they encoded them at time of output. Fair enough? No. Actually they implemented half of the recommendations- ie. they worked on blacklisting and left out whitelisting. There are a number of models to think about when designing a data validation strategy, which are listed from the strongest to the weakest as follows. 1.Exact Match (Constrain) 2.Known Good (Accept) 3.Reject Known bad (Reject) 4.Encode Known bad (Sanitize) They were implementing last two of strategies only. So the application was now filtering out normal XSS vectors like "><script>alert(...);</script> based attacks. But what happens when we provide eventhalders like onmouseover,onload etc-XSS executed. When we brought this to customers' notice they said that alphabets and " (double quotes) are valid inputs in the comment fileds, how can we filter them out, not even whitelisting approach will work here as these are valid characters. So after a brainstorming session with them we advised them to mould as per their need. It's not like that you blindly follow strategies mentioned above for whole application. We suggested them for that specific case where " (double quotes) and alphabets were valid inputs (in comments fields) don't filter " (double quotes) but atleast filter even handlers-onload,onfocus etc by using this sample script: .replaceAll("(?i)<.*?\\s+on.*?>.*?", "");

It removes on* attributes like onLoad or onClick

My point is that in some cases you need to shape your strategies as per your need to strike a fine balance between security and user-friendliness.

Comments

530 Geeks said…
What you are recommending is incorrect.

The only way to solve XSS is Escaping Output. Input Validation has NOTHING to do with XSS prevention.

Refer to OWASP's XSS Prevention cheat sheet. There are specific rules for encoding attribute values. If you follow OWASP's recommendation, your application can accept any string and still display it back to the user without any XSS.

There is no need to mould security on an application basis. OWASPs recommendations for XSS are good enough to fix XSS in all kinds of websites.
Nilesh Kumar said…
Hi 530 Geeks,

Thanks for your valuable comments!

I can understand what you are saying. I have already mentioned the about encoding (4.Encode Known bad (Sanitise)) in my blog. They are doing that also. But in the case of their comment field if they encode " it comes as &quotes; which doesn't look good.
What I want to say is sometimes you have to make a balance between security and user-friendliness.

Regards,
Nilesh
530 Geeks said…
If it appears as & q u o t ; , they are not escaping/encoding it properly. I suspect they are double encoding. It perhaps appears as & a m p ; q u o t ; in the HTML.

I am trying to say that "Escaping Output" is alone sufficient for a usable and secure website. Input Validation helps, but it neither necessary nor fool-proof.

Popular posts from this blog

File Upload through Null Byte Injection

Sometimes, during file upload we come across situation wherein there would be check on the file extension at the client side as well as server side too. If the application does allow only .jpeg extension to be uploaded, the client side java script checks for the extension of the file before passing the request. We all know that how easily this can be defeated. Some applications, checks for the extension at the server side also. That's not easy to bypass. However there are some ways with which it still can be bypassed. Most of server side scripts are written in high level languages such as Php, Java etc who still use some C/C++ libraries to read the file name and contents. That leads to the problem. In C/C++ a line ends with /00 or which is called Null Byte. So whenever the interpreter sees a null byte at the end of the a string, it stops reading thinking it has reached at the end of the string. This can be used for the bypass. It works for many servers, specially php servers. T...

'Information Leakage-Improper Error Handling' dropped

From Owasp Top 10 2010 List, the issue 'Information Leakage-Improper Error Handling' has been dropped. But it's not the final list,its child release actually. Bu I feel it shouldn't be set aside because its still the one of the prevalent issues these days. That's why I mailed to Dave Wicher: Hi Dave, Excellent work, Congrats! Just one little query- Don't you think that Information Leakage & Improper Error Handling still deserves to be in Top 10? Dave replied: This topic is clearly a very prevalent issue that deserves attention by most organizations. However, the typical impact of such a flaw is usually very low. Therefore, the overall risk of this type of flaw is lower than the other items in the top 10, which is why it was replaced in this update with one of the 2 new items. Regarding dropping Info Leak/Error handling - It is incredibly prevalent, no question. But their impact is typically very low, so the overall risk is low, which is why it fell out of t...

jtool - an alternative to otool

jtool comes with a capability of running on Linux environment. Some ipa scanning tools are created to run on Linux environment where mac environment is not available. In such cases tools such as otool and class-dump-z will not work. So jtool can be an alternative to otool. For more information on jtool please refer to http://www.newosxbook.com/tools/jtool.html . It lists down various commands which have same output as otool or a equivalent. There are several commands mentioned in link. But for our customized requirements and basis checks I have listed down the below ones after running on many binaries. The outputs are similar or equivalent to otool and class-dump-z: Commands for checking PIE flag (ASLR) in jTool jtool -d -v -arch | grep stack ·           Automatic Reference Counting (ARC) protection: jtool -d -v -arch | grep _objc_release ·           To check if the devic...